feat(cqn4sql/infer): support for deep search #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this basically is a copy of the functionality of the coding of the orignal function. Removed deprecated code and simplified it a little.
This reverts commit f5f5954.
patricebender
changed the title
patricebender
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
patricebender
added a commit
that referenced
this pull request
Apr 16, 2024
support search via path expressions: - deep search via associations - include calculated elements if explicitly requested - keep existing caching mechanisms --- rework of #252
|
Closed in favor of #590 |
patricebender
added a commit
that referenced
this pull request
Jul 8, 2024
support search via path expressions: - deep search via associations - include calculated elements if explicitly requested --- with `cds.infer` being a part of all our query objects, each query comes with `target` and `elements` even without the `infer` function of the `db-service`being called. Hence, it was possible to calculate the search term as a very first step of `cqn4sql`. After the `contains(…)` function has been added to the queries `where` or `having` clause the usual join tree algorithm is executed, making it possible to use path expressions within the search term. --- rework of #252 --------- Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support search via path expressions:
based on #248